HIVE-26484: Add proto3 hivemetastore.proto #3784
Conversation
deniskuzZ
changed the title
Noremac201
force-pushed
the
HIVE-26484
branch
from
a8824de
to
fd706df
Compare
There was a problem hiding this comment.
+1 (non-binding)
Thank you for this contribution, @Noremac201 and @rohansonecha !
kgyrtkirk
added
tests passed
tests pending
tests failed
and removed
tests pending
tests passed
labels
Change-Id: I38dd936e4ad710e05e95d78f05b5e07585cb1660
deniskuzZ
force-pushed
the
HIVE-26484
branch
from
fd706df
to
09ba96d
Compare
|
rebased again |
|
Kudos, SonarCloud Quality Gate passed!
|
…by Chris Nauroth, Denys Kuzmenko) Co-authored-by: Rohan Sonecha Closes apache#3784
…by Chris Nauroth, Denys Kuzmenko) Co-authored-by: Rohan Sonecha Closes apache#3784 (cherry picked from commit 585eac4)
|
@cnauroth @deniskuzZ, one question: Any specific reason why guava version was not upgraded in standalone-metastore/pom.xml and storage-api/pom.xml? It is still 19.0! |
PR mentions that proto3/grpc won't compile with guava < 22, however, looks like standalane-metastore's root pom overrides it with v19. Not sure how it compiled then in the first place, maybe a version upgrade wasn't required. There was no further contribution since the initial proto file generation, we might consider reverting this PR. |
|
I'm guessing this was an oversight, not an intentional choice to leave Guava at 19.0. @Noremac201 , maybe you'd be interested in sending a follow-up PR to upgrade Guava to 22.0 in standalone-metastore/pom.xml and storage-api/pom.xml? |
…by Chris Nauroth, Denys Kuzmenko) Co-authored-by: Rohan Sonecha Closes apache#3784
…by Chris Nauroth, Denys Kuzmenko) Co-authored-by: Rohan Sonecha Closes apache#3784
This is a rebased version of #3534,
What changes were proposed in this pull request?
hive_metastore.thriftfile.As this is "new" API, the new grpc API doesn’t include the same method with different signature, i.e. get_databases(string db_id) is usurped by get_databases(GetDatabasesRequest request).
Why are the changes needed?
The proto file is necessary because in order to have native gRPC support in Hive Metastore, there needs to be gRPC equivalents of all the preexisting Thrift objects as well as method header definitions in gRPC for Thrift counterparts.
Does this PR introduce any user-facing change?
Not yet, while this will allow developers to use this proto to generate clients (i.e. in Impala) before full support for gRPC is added in Hive Metastore.
How was this patch tested?
No tests were added in this PR other than making sure that the proto file and pom.xml files compile without issues and checking the target/ directory for generated files.