HIVE-26758: Allow use scratchdir for staging final job #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunchao
approved these changes
Dec 5, 2022
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
Outdated
Show resolved
Hide resolved
|
thanks @sunchao for the review! addressed comments |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Merged to master, thanks @yigress ! |
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 16, 2022
DongWei-4
pushed a commit
to DongWei-4/hive
that referenced
this pull request
Dec 29, 2022
(cherry picked from commit 6de98ba)
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add a hive configuration hive.use.scratchdir.for.staging
for native table, no-mm, no-direct-insert, no-acid, change dynamic partition staging directory layout from
<dest_path>/<static_partition>/<staging_dir>/<dynamic_partition>
to
<dest_path>/<staging_dir>/<static_partition>/<dynamic_partition>
when hive.use.scratchdir.for.staging=true, FileSinkOperator's dirName, DynamicContext's sourcePath change from
<dest_path>/{hive.exec.stagingdir}
to
<hive.exec.scratchdir>
for example for query
insert into/overwrite table partition(year=2001, season) select...
before the change, the FileSinkOperator conf has
<table_path>/year=2001/.staging_dir/season=xxx
after the change, it has
<table_path>/.staging_dir/year=2001/season=xxx
This change allow to swap <table_path> with another path such as <hive.exec.scratchdir>, and the moveTask will move into <table_path>
Why are the changes needed?
In the S3 blobstorage optimization, HIVE-15121 / HIVE-17620 changed interim job path to use hive.exec.scracthdir, final job to use hive.exec.stagingdir. https://issues.apache.org/jira/browse/HIVE-15215 is open whether to use scratch for staging dir for S3.
However for blobstorage where 'rename' is slow and no encryption, it can help performance to use scratchdir to staging query results and use the MoveTask to copy to blobstorage. This is especially true when there is FileMerge task.
This may also help cross-filesystem when user wants to use local cluster filesystem to staging query results and move the results to destination filesystem.
Does this PR introduce any user-facing change?
This adds a new hive configuration.
How was this patch tested?