HIVE-26892: Backport HIVE-25243 to 3.2.0: Handle nested values in null struct. #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abstractdog Can you please review and merge this. |
abstractdog
approved these changes
Jan 10, 2023
amanraj2520
pushed a commit
to amanraj2520/hive
that referenced
this pull request
Jan 15, 2023
…l struct. (apache#3898) (branch-3 backport by Aman Raj reviewed by Laszlo Bodor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HIVE-26892: Backport HIVE-25243 to 3.2.0: Handle nested values in null struct.
This differs from the original patch as follows:
TestJdbcWithMiniLlapVectorArrow. This file does not exist in branch-3. The original patch was only a whitespace change though.TestMiniLlapVectorArrowWithLlapIODisabled. This test suite depends on an additional feature that is only present in master: HIVE-20300 / a8ef214. This is a fairly large patch that I have not chosen to try backporting at this time.Why are the changes needed?
On branch-3, we've seen a failure in
TestArrowColumnarBatchSerDewhile trying to serialize a row of null values. It fails while trying to serialize the fields of a null struct. This was fixed in 4.0 by HIVE-25243. This issue tracks a backport to branch-3.Does this PR introduce any user-facing change?
Null structs are now serialized to Arrow format correctly without error.
How was this patch tested?
Unfortunately, we are left with no specific new tests as part of this backport. However, I applied this patch locally in combination with HIVE-26840 / #3859. After that, all tests in
TestArrowColumnarBatchSerDeare passing.