HIVE-27055: hive-exec typos part 3 #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
kgyrtkirk
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
|
@abstractdog any chance you could review it? |
abstractdog
reviewed
Feb 23, 2023
| @@ -798,7 +798,7 @@ && shouldBootstrapDumpAcidTable(table.getTableName())) { | |||
| return !ReplUtils.tableIncludedInReplScope(work.oldReplScope, table.getTableName()); | |||
| } | |||
|
|
|||
| private boolean isTableSatifiesConfig(Table table) { | |||
| private boolean isTableSatisfiesConfig(Table table) { | |||
There was a problem hiding this comment.
if we're about grammar, and this is a private method (we won't break anything), isn't it "doesTableSatisfyConfig instead?
abstractdog
requested changes
Feb 23, 2023
kgyrtkirk
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
|
Kudos, SonarCloud Quality Gate passed!
|
mlorek
requested review from
abstractdog
and removed request for
ayushtkn,
miklosgergely and
pgaref
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…ed by Laszlo Bodor)
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…ed by Laszlo Bodor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix typos in comments and code
Why are the changes needed?
to improve code quality
Does this PR introduce any user-facing change?
No (except debug logging)
How was this patch tested?
build