Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hive18799 #407

Closed
wants to merge 9 commits into from
Closed

Hive18799 #407

wants to merge 9 commits into from

Conversation

alanfgates
Copy link
Contributor

This is based off of Harsha's pull request #393 . I made the following changes:

  1. I rebased it against master. Since the metastore is now split into common and server, I put all of the client stuff in a new module standalone-metastore/registry-client and the server stuff into metastore-server. Harsha, feedback on whether I put the right things in the right places would be helpful.
  2. I fixed one thrift request that had multiple arguments rather than a struct.

There are no tests in this code. That's a problem, since this is a lot of code. I assume there are tests for this code in the current registry project. Did you intend to move them separately?

@harshach
Copy link

harshach commented Aug 2, 2018

@alanfgates I might have missed the tests. Let me add those.

@alanfgates
Copy link
Contributor Author

@harshach Note, this also only has DB changes for the hive 4.0 installation on derby. It needs to be added to the upgrade path for derby (should be the 3.2 to 4.0 script) and both installation and upgrade on mysql, mssql, oracle, and postgres.

@github-actions
Copy link

github-actions bot commented Jun 9, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Jun 9, 2020
@github-actions github-actions bot closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants