-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-27164: Create temporary insert only/full acid table fails at metastore transformCreateTable #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@saihemanth-cloudera @dengzhhu653 Can you please review? |
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestTempAcidTable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit(s) otherwise looks good.
d87eaa8
to
2012f5c
Compare
2012f5c
to
eb11128
Compare
…astore transformCreateTable
eb11128
to
a106cd3
Compare
Kudos, SonarCloud Quality Gate passed! |
saihemanth-cloudera
approved these changes
Apr 12, 2023
subhasisgorai
pushed a commit
to subhasisgorai/hive
that referenced
this pull request
Apr 14, 2023
…astore transformCreateTable (apache#4176) (Venugopal Reddy K, reviewed by Sai Hemanth G)
henrib
pushed a commit
to henrib/hive
that referenced
this pull request
Apr 24, 2023
…astore transformCreateTable (apache#4176) (Venugopal Reddy K, reviewed by Sai Hemanth G)
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…astore transformCreateTable (apache#4176) (Venugopal Reddy K, reviewed by Sai Hemanth G)
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…astore transformCreateTable (apache#4176) (Venugopal Reddy K, reviewed by Sai Hemanth G)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added
SessionHiveMetaStoreClient.getTranslateTableDryrun()
that detects the temporary tables and process it.Why are the changes needed?
Temporary tables are in-memory tables maintained per session at HS2. They not managed at HMS. API calls to HMS are intercepted and processed at
SessionHiveMetaStoreClient
itself for the temporary tables. But missed to intercept forgetTranslateTableDryrun()
API.Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested the scenario manually and added unittests