Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-27164: Create temporary insert only/full acid table fails at metastore transformCreateTable #4176

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

VenuReddy2103
Copy link
Contributor

What changes were proposed in this pull request?

Added SessionHiveMetaStoreClient.getTranslateTableDryrun() that detects the temporary tables and process it.

Why are the changes needed?

Temporary tables are in-memory tables maintained per session at HS2. They not managed at HMS. API calls to HMS are intercepted and processed at SessionHiveMetaStoreClient itself for the temporary tables. But missed to intercept for getTranslateTableDryrun() API.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Tested the scenario manually and added unittests

@nrg4878
Copy link
Contributor

nrg4878 commented Mar 31, 2023

@saihemanth-cloudera @dengzhhu653 Can you please review?

Copy link
Contributor

@saihemanth-cloudera saihemanth-cloudera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit(s) otherwise looks good.

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saihemanth-cloudera saihemanth-cloudera merged commit 1f5e9c1 into apache:master Apr 12, 2023
subhasisgorai pushed a commit to subhasisgorai/hive that referenced this pull request Apr 14, 2023
…astore transformCreateTable (apache#4176) (Venugopal Reddy K, reviewed by Sai Hemanth G)
henrib pushed a commit to henrib/hive that referenced this pull request Apr 24, 2023
…astore transformCreateTable (apache#4176) (Venugopal Reddy K, reviewed by Sai Hemanth G)
yeahyung pushed a commit to yeahyung/hive that referenced this pull request Jul 20, 2023
…astore transformCreateTable (apache#4176) (Venugopal Reddy K, reviewed by Sai Hemanth G)
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
…astore transformCreateTable (apache#4176) (Venugopal Reddy K, reviewed by Sai Hemanth G)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants