HIVE-27268: synthetize empty id lists if no session available #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
- servlet server will not start if port is not configured;
…titions() on a tx table;
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
…nto HIVE-27268" This reverts commit d39df85.
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a tool runs without a session, create an empty id list.
Why are the changes needed?
To avoid a potential NPE and be consistent.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Very hard to produce through unit tests (need to fail session creation).