HIVE-27447: Iceberg: Queries failing due to FileSystem close errors due to column statistics. #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue to column statistics.
kgyrtkirk
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
|
Kudos, SonarCloud Quality Gate passed!
|
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…ue to column statistics. (apache#4429). (Ayush Saxena, reviewed by Denys Kuzmenko,)
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…ue to column statistics. (apache#4429). (Ayush Saxena, reviewed by Denys Kuzmenko,)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid closing FIleSystem during column statistics stage. FileSystem instance is cached across the service, If we close one and some other thread tries to use that cached FS, it will fail with FS Closed Errors.
Second,
Closing & Recreating a new FS every time is costly, as the FS needs to be initialised every time & hence it shouldn't be closed mid way.
Why are the changes needed?
Avoid FS Close Errors
Does this PR introduce any user-facing change?
Queries doesn't fail with FS close error when using column stats source as Iceberg
Is the change a dependency upgrade?
No