Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-27448: Hive Iceberg: Merge column stats #4431

Merged
merged 6 commits into from Jul 26, 2023

Conversation

simhadri-g
Copy link
Member

@simhadri-g simhadri-g commented Jun 18, 2023

What changes were proposed in this pull request?

  1. Merge and update column stats after insert queries.
  2. Update describe formatted to read stats from puffin file.

    Why are the changes needed?

    Hive only calculates the col stats for the rows inserted in a query.
    We will need to merge these stats with the existing stats of the table to get the accurate values.

    Does this PR introduce any user-facing change?

    Is the change a dependency upgrade?

    How was this patch tested?

    Unit test: TestHiveIcebergColStats
    qtests

Copy link
Member

@deniskuzZ deniskuzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 pending tests

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@deniskuzZ deniskuzZ merged commit 9d81764 into apache:master Jul 26, 2023
5 checks passed
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
… reviewed by Denys Kuzmenko, Krisztian Kasa, Sourabh Badhya)

Closes apache#4431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants