New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-27448: Hive Iceberg: Merge column stats #4431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simhadri-g
force-pushed
the
hive-stats-merge
branch
from
June 20, 2023 13:10
1d6cc0c
to
7d07744
Compare
simhadri-g
changed the title
[WIP - do not review] HIVE-27448: Hive Iceberg: Merge column stats
HIVE-27448: Hive Iceberg: Merge column stats
Jun 20, 2023
simhadri-g
force-pushed
the
hive-stats-merge
branch
from
June 20, 2023 23:04
7d07744
to
208106b
Compare
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
Jun 20, 2023
simhadri-g
force-pushed
the
hive-stats-merge
branch
from
June 21, 2023 08:16
208106b
to
80ba369
Compare
simhadri-g
force-pushed
the
hive-stats-merge
branch
from
June 21, 2023 14:54
80ba369
to
59a4441
Compare
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
Jun 21, 2023
deniskuzZ
reviewed
Jun 22, 2023
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 22, 2023
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 22, 2023
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests failed
tests pending
tests passed
tests unstable
and removed
tests pending
tests failed
tests passed
tests unstable
labels
Jul 18, 2023
deniskuzZ
reviewed
Jul 25, 2023
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jul 25, 2023
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java
Outdated
Show resolved
Hide resolved
simhadri-g
force-pushed
the
hive-stats-merge
branch
from
July 25, 2023 09:54
8fd5e40
to
15ba46d
Compare
deniskuzZ
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1 pending tests
Kudos, SonarCloud Quality Gate passed! |
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
… reviewed by Denys Kuzmenko, Krisztian Kasa, Sourabh Badhya) Closes apache#4431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Hive only calculates the col stats for the rows inserted in a query.
We will need to merge these stats with the existing stats of the table to get the accurate values.
Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
How was this patch tested?
Unit test: TestHiveIcebergColStats
qtests