Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-27478: Remove re2j, SQLLine, ClassNameCompleter entries from LICENSE file #4462

Closed
wants to merge 1 commit into from

Conversation

zabetak
Copy link
Contributor

@zabetak zabetak commented Jun 30, 2023

What changes were proposed in this pull request?

  1. Remove SQLLine entry from LICENSE.
  2. Update SQLLine LICENSE based on the version we use and add it in binary-package-licenses.
  3. Remove re2j entry from LICENSE and move it to binary-package-licenses.
  4. Remove obsolete ClassNameCompleter entry from LICENSE (class no longer present in the repo).

SQLLine license URL: https://github.com/julianhyde/sqlline/blob/sqlline-1.9.0/LICENSE
re2j license URL: https://github.com/google/re2j/blob/re2j-1.2/LICENSE

Why are the changes needed?

Comply with ASF policy around the content of LICENSE file; only bundled bits should be mentioned.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

Not needed.

…ENSE file

1. Remove SQLLine entry from LICENSE.
2. Update SQLLine LICENSE based on the version we use and add it in binary-package-licenses.
3. Remove re2j entry from LICENSE and move it to binary-package-licenses.
4. Remove obsolete ClassNameCompleter entry from LICENSE (class no longer present in the repo).

SQLLine license URL: https://github.com/julianhyde/sqlline/blob/sqlline-1.9.0/LICENSE
re2j license URL: https://github.com/google/re2j/blob/re2j-1.2/LICENSE
Copy link

@aturoczy aturoczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zabetak zabetak closed this in f8a92b1 Jul 3, 2023
yeahyung pushed a commit to yeahyung/hive that referenced this pull request Jul 20, 2023
…ENSE file (Stamatis Zampetakis reviewed by Attila Turoczy, Ayush Saxena)

1. Remove SQLLine entry from LICENSE.
2. Update SQLLine LICENSE based on the version we use and add it in binary-package-licenses.
3. Remove re2j entry from LICENSE and move it to binary-package-licenses.
4. Remove obsolete ClassNameCompleter entry from LICENSE (class no longer present in the repo).

SQLLine license URL: https://github.com/julianhyde/sqlline/blob/sqlline-1.9.0/LICENSE
re2j license URL: https://github.com/google/re2j/blob/re2j-1.2/LICENSE

Closes apache#4462
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
…ENSE file (Stamatis Zampetakis reviewed by Attila Turoczy, Ayush Saxena)

1. Remove SQLLine entry from LICENSE.
2. Update SQLLine LICENSE based on the version we use and add it in binary-package-licenses.
3. Remove re2j entry from LICENSE and move it to binary-package-licenses.
4. Remove obsolete ClassNameCompleter entry from LICENSE (class no longer present in the repo).

SQLLine license URL: https://github.com/julianhyde/sqlline/blob/sqlline-1.9.0/LICENSE
re2j license URL: https://github.com/google/re2j/blob/re2j-1.2/LICENSE

Closes apache#4462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants