HIVE-27488: HPL/SQL Quote literals not behaving as expected #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
zabetak
reviewed
Jul 12, 2023
kgyrtkirk
added
tests pending
tests failed
and removed
tests passed
tests pending
tests failed
labels
|
Kudos, SonarCloud Quality Gate passed!
|
zabetak
approved these changes
Jul 18, 2023
| public class TestUtils { | ||
|
|
||
| @Test | ||
| public void testShouldRemoveEscapeCharactersFromTheGivenInput() { |
There was a problem hiding this comment.
We should include the name of the method that is tested. Something like:
testUnquoteStringRemovesOneQuoteWhenTwoConsecutive
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
… M reviewed by Attila Turoczy, Stamatis Zampetakis) Closes apache#4476
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
… M reviewed by Attila Turoczy, Stamatis Zampetakis) Closes apache#4476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Now including single quote(') in the output if the last two characters are single quotes(').
Why are the changes needed?
To fix the issue 'HIVE-27488: HPL/SQL Quote literals not behaving as expected'.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Tests are added.