New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-27585 Upgrade kryo serialization lib to latest version #4570
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
@ayushtkn PTAL if you don't mind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ayushtkn Thank you for the quick review, when do you plan to merge this? |
@@ -29,7 +29,7 @@ | |||
<kryo-shaded.version>4.0.3</kryo-shaded.version> | |||
<iceberg.mockito-core.version>3.4.4</iceberg.mockito-core.version> | |||
<iceberg.avro.version>1.11.1</iceberg.avro.version> | |||
<iceberg.kryo.version>5.2.0</iceberg.kryo.version> | |||
<iceberg.kryo.version>5.5.0</iceberg.kryo.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may break hive - spark interoperability if spark is not on the same version of kryo.
Can you please check once?
@simhadri-g What version of spark uses? We are already on 5.2.0, shouldn't spark also upgrade if they want to use our latest version of hive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Could you please insert the jira ticket in the description?
Seems like spark is not very keen on upgrading kryo version . They are most likely on 4.0.2 : I think we can go ahead with the upgrade in hive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM+1
…4570). (Suprith Chandrashekharachar, reviewed by Ayush Saxena, Attila Turoczy, Simhadri Govindappa)
…4570). (Suprith Chandrashekharachar, reviewed by Ayush Saxena, Attila Turoczy, Simhadri Govindappa)
What changes were proposed in this pull request?
Upgrade kryo serialization lib to latest version.
https://issues.apache.org/jira/browse/HIVE-27585
Why are the changes needed?
Consumes some latest improvements and bug fixes
EsotericSoftware/kryo@kryo-parent-5.2.0...kryo-parent-5.5.0.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
Yes. Attached file
How was this patch tested?
Existing tests