HIVE-21213: Acid table bootstrap replication needs to handle director… #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rakshith606
force-pushed
the
HIVE-21213
branch
from
0975d5d
to
3474153
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
pudidic
approved these changes
Aug 29, 2023
pudidic
requested changes
Aug 29, 2023
Rakshith606
force-pushed
the
HIVE-21213
branch
from
3474153
to
24fe805
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
…y created by compaction with txn id
Rakshith606
force-pushed
the
HIVE-21213
branch
from
24fe805
to
bf5521d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
LGTM +1. |
pudidic
approved these changes
Sep 1, 2023
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…y created by compaction with txn id (apache#4631) (Rakshith C, reviewed by Teddy Choi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Stripping visibility prefix of compacted files when bootstrap replication is done.
Why are the changes needed?
When REPL DUMP is issued against a database whose tables have undergone major compaction, base_xxx_vxxx files are copied onto replica without stripping vxxx.
The file may not be visible on target because the current transaction ID may be much lesser than vxxx.
Since REPL DUMP opens a read-only transaction, if base_xxxx_vxxx was visible to REPL_DUMP on source, it has to be made visible on target as well.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?