HIVE-23680 : TestDbNotificationListener is unstable #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original PR |
asf-ci-hive
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Original PR #4497
was merged to stream but had to revert because of mockito changes. Rerasing this PR after fixing mockito change
https://issues.apache.org/jira/browse/HIVE-23680
TestDbNotificationListener was flakey as well as broken .
As a part of fix, There are nowtotal 3 test classes based on broken tests in TestDbNotificationListener
TestDbNotificationListener
Fix of existing tests which includes nontransactional events
TestDbNotificationCleanup
This class includes tests which asserts cleanup of events based on TTL configurations
TestTransactionalDbNotificationListner
This class included tests with transactional event. This needs extra HMS test setup and acid properties setting.
Why are the changes needed?
TestDbNotificationListener is broken
http://34.66.156.144:8080/job/hive-precommit/job/master/35/testReport/
http://130.211.9.232/job/hive-flaky-check/24/
Does this PR introduce any user-facing change?
NO
Is the change a dependency upgrade?
NO
How was this patch tested?
http://ci.hive.apache.org/job/hive-flaky-check/722/
http://ci.hive.apache.org/job/hive-flaky-check/721/
http://ci.hive.apache.org/job/hive-flaky-check/720/