-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-21100: Allow flattening of table subdirectories resulted when using TEZ engine and UNION clause. #4730
Conversation
…ing TEZ engine and UNION clause.
|
||
explain insert overwrite table test2 partition (dt='20230817') select ful.* from (select val from test2 where dt='20230816') ful left join (select val from test1 where dt='20230817') inc on ful.val=inc.val union all select test1.val from test1 where dt='20230817'; | ||
|
||
insert overwrite table test2 partition (dt='20230817') select ful.* from (select val from test2 where dt='20230816') ful left join (select val from test1 where dt='20230817') inc on ful.val=inc.val union all select test1.val from test1 where dt='20230817'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test should be extended to certain scenarios:
- acid/mm/non-acid
- direct insert on/off
- union flattening on/off
create different tables for different scenarios:
union_target_acid_directinsert_flattened
union_target_mm_directinsert_flattened
union_target_nonacid_directinsert_flattened
union_target_acid_nodirectinsert_flattened
union_target_mm_nodirectinsert_flattened
union_target_nonacid_nodirectinsert_flattened
union_target_acid_directinsert_noflattened
union_target_mm_directinsert_noflattened
union_target_nonacid_directinsert_noflattened
union_target_acid_nodirectinsert_noflattened
union_target_mm_nodirectinsert_noflattened
union_target_nonacid_nodirectinsert_noflattened
|
||
select * from union_target_acid_unflattened; | ||
|
||
-- TESTS FOR DIRECT & NON FLATEENED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: FLATTENED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eagle eye :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Seems ok to me. Wait for the test
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Have fixed the typo. The last failure was some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…ing TEZ engine and UNION clause. (apache#4730). (Ayush Saxena, reviewed by Laszlo Bodor)
What changes were proposed in this pull request?
Allow to flatten subdir in case of UNION
Why are the changes needed?
To avoid Subdir in case of UNION queries for compar
Does this PR introduce any user-facing change?
Yes, if the config is turned on.
Is the change a dependency upgrade?
No
How was this patch tested?
UT