HIVE-27752: Remove DagUtils duplicate class #4756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstractdog
reviewed
Sep 28, 2023
| @@ -227,6 +228,14 @@ public Object process(Node nd, Stack<Node> stack, NodeProcessorCtx procCtx, | |||
| return null; | |||
| } | |||
| } | |||
| public static String getQueryName(Configuration conf) { | |||
There was a problem hiding this comment.
you haven't needed to change any reference? isn't this used at all? if so, I'm fine with removing it :)
There was a problem hiding this comment.
Yup, no usage that the ide could detect as well, will remove it :)
|
Kudos, SonarCloud Quality Gate passed!
|
akshat0395
force-pushed
the
HIVE-27752
branch
from
f52b59c
to
5da6ffd
Compare
|
previous precommit passed, it makes no sense to wait for this one |
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…hur reviewed by Laszlo Bodor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove DagUtils duplicate class, after DagUtils.java in tez package
Why are the changes needed?
Code cleanup
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Existing Unit test