-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-27871: Fix formatting problems is YarnQueueHelper #4874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a comment here:
https://issues.apache.org/jira/browse/HIVE-27871?focusedCommentId=17785948&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17785948
It is not addressed here, we should handle all the logger lines in this file.
On a side note: I am not sure about this coding practice, why someone needs to define these constants, could have directly used the already defined ones RM_WEBAPP_ADDRESS
and so, anyway....
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java
Outdated
Show resolved
Hide resolved
I agree with @ayushtkn, these static constants make sense if you use it 10-20 times in a class, but that's not the case here, I would simply purge them them and use directly YarnConfiguration |
6111208
to
3a061f9
Compare
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java
Outdated
Show resolved
Hide resolved
3a061f9
to
231f283
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…(Mahesh Raju Somalaraju reviewed by Laszlo Bodor, Ayush Saxena)
What changes were proposed in this pull request?
Fix formatting problems is YarnQueueHelper
Why are the changes needed?
For better code readability
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Fix formatting only. no functionality involved