HIVE-20897 : TestJdbcDriver2#testSelectExecAsync2 fails with result set not present error #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et not present error
sankarh
reviewed
Nov 28, 2018
| @@ -53,14 +53,19 @@ public void setHasResultSet(boolean hasResultSet) { | |||
| } | |||
|
|
|||
| public boolean hasResultSet() { | |||
| return hasResultSet; | |||
| // null check to retain the old behavior | |||
There was a problem hiding this comment.
No change needed in OperationHandle.java as we still return false if not set. Also, new method isHasResultSetIsSet is unused.
| @@ -61,7 +61,7 @@ | |||
| private final OperationHandle opHandle; | |||
| public static final FetchOrientation DEFAULT_FETCH_ORIENTATION = FetchOrientation.FETCH_NEXT; | |||
| public static final Logger LOG = LoggerFactory.getLogger(Operation.class.getName()); | |||
| protected boolean hasResultSet; | |||
| protected Boolean hasResultSet = null; | |||
There was a problem hiding this comment.
Can revert back to be primitive boolean itself as we always return false if it is null.
There was a problem hiding this comment.
it is required for constructing OperationStatus
…hive.strict.managed.tables enabled
maheshk114
force-pushed
the
HIVE-20897-review
branch
from
673a910
to
457eba5
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…