HIVE-27977: Fix ordering flakiness in TestHplSqlViaBeeLine #4994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mdayakar
pushed a commit
to mdayakar/hive
that referenced
this pull request
Jan 15, 2024
…) (Laszlo Bodor reviewed by Butao Zhang, Ayush Saxena)
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Feb 9, 2024
…) (Laszlo Bodor reviewed by Butao Zhang, Ayush Saxena)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…) (Laszlo Bodor reviewed by Butao Zhang, Ayush Saxena)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce ORDER BY clause in some unit tests.
Why are the changes needed?
Bumped into intermittent test failures in TestHplSqlViaBeeLine while moving it from MR to Tez, and realized that the ordering is not defined in the test cases, so it makes no sense to look for the execution engine differences as long as we don't have a stable golden output.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
With the touched unit tests.