HIVE-26713: StringExpr ArrayIndexOutOfBoundsException with LIKE '%xxx%' #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangbutao
reviewed
Jan 11, 2024
storage-api/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestStringExpr.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
zhangbutao
reviewed
Jan 13, 2024
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
zhangbutao
approved these changes
Jan 15, 2024
zhangbutao
reviewed
Jan 15, 2024
storage-api/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestStringExpr.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
aturoczy
approved these changes
Jan 16, 2024
|
@ryukobayashi You can rebase this PR to get a green CI. |
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
|
Can you rebase your PR ? |
|
|
@zhangbutao Sorry for the late reply. The latest master is now green, so I merged it and this PR test also became green. |
|
Thanks. |
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Feb 9, 2024
…%' (apache#4999)(Ryu Kobayashi, reviewed by Attila Turoczy, Butao Zhang)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…%' (apache#4999)(Ryu Kobayashi, reviewed by Attila Turoczy, Butao Zhang)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When LIKE(%xxx%) search is performed, if the character string contains control characters, overflow occurs.
Why are the changes needed?
ArrayIndexOutOfBoundsException will occur if the input data contains a control code, etc.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added testcase as part of PR.