HIVE-28000: Fix scenarios where 'not in' gives incorrect results due to type coercion

[AnmolSun]

There are certain scenarios where "not in" clause gives incorrect results when type coercion cannot take place.

These occur when the in clause contains at least one operand which cannot be type-coerced to the column on which the in clause is being applied to.

JIIRA - HIVE-28000

A similar fix was done in HIVE-24817 but that does not work for the cases mentioned above.

The proposed solution in the PR is to ignore those operands completely inside the "in" clause which cannot be type coerced. We then check if it is indeed the case where none of the operands in the "in" clause can be type coerced and we return false if that is the case.

For example:

CREATE TABLE my_tbl (id int);
insert into my_tbl values (100),(200),(300);

select * from my_tbl where id not in ('ABC', 'DEF', '100');
we will ignore all those operands which cannot be type coerced, so on a high level, it will be translated to :
select * from my_tbl where id not in ('100');

select * from my_tbl where id not in ('ABC', 'DEF');
we will ignore all those operands which cannot be type coerced, since none of the operands can be type coerced, on a high level, it is framed as :
select * from my_tbl where id not <expression:false>
which would further imply that
select * from my_tbl where <expression:true>

In case of boolean operands, we only support those operands inside the "in" clause, i.e. only boolean values, otherwise the query fails. As a result, this change does not impact boolean operations.

I have added more q tests and the existing tests are passing in CI/CD.

[aturoczy]

I'm not familiar with this code place. @kasakrisz could you pls check? I feel this type of change could cause more issue.

Meanwhile could you please add the jira and the description to the PR

[AnmolSun]

Hello @aturoczy and @kasakrisz ,
This patch is still WIP. There are some tests that are failing for now - I haven't got the chance to fix them yet. I'll add more details on the patch once we get a green run in tests.
I'm sorry I missed converting this to a draft earlier.

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[AnmolSun]

Hello @aturoczy and @kasakrisz ,
Could you please help take a look. I have updated the description and we have a green CI/CD run.

[kasakrisz]

The change looks good to me.
@scarlin-cloudera Could you please take a look?

[scarlin-cloudera]

LGTM