HIVE-28002: Make hive.metastore.batch.retrieve.max property to be read from hiveconf in HS2 #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aturoczy
reviewed
Jan 16, 2024
| @@ -1296,10 +1296,7 @@ public static enum ConfVars { | |||
| @Deprecated | |||
| METASTORE_PLUGIN_REGISTRY_BUNDLE_CHECK("datanucleus.plugin.pluginRegistryBundleCheck", "LOG", | |||
| "Defines what happens when plugin bundles are found and are duplicated [EXCEPTION|LOG|NONE]"), | |||
| /** | |||
There was a problem hiding this comment.
It is not deprecated before? Or why it is changed?
|
-1 |
|
The main motivation behind this PR was to increase readability wrt HS2 accessing only HiveConf and HMS accessing only MetastoreConf to have a clear demarkation. I will close this PR wrt the above comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The property hive.metastore.batch.retrieve.max is used by both the client(Hs2) and the HMS when fetching objects(tables/partitions) in batches. This property is present in both hiveConf.java as well as metastoreConf.java. For some use cases in the client(Hs2), this value is referred from the metastoreConf. Changing those use cases to HiveConf.java to have a set demarkation between HS2 and HMS use cases for this property.
Why are the changes needed?
Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
How was this patch tested?