New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28008: Missing try-with-resources in ParquetHiveSerDe #5013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this change to get a green CI?
cc @ayushtkn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@zhangbutao is it good with you to merge this, we have a green build now. I am holding this for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…chema (apache#5013). (Michal Lorek, reviewed by Ayush Saxena, Butao Zhang, Attila Turoczy)
…chema (apache#5013). (Michal Lorek, reviewed by Ayush Saxena, Butao Zhang, Attila Turoczy)
What changes were proposed in this pull request?
missing
close
callWhy are the changes needed?
release resources
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
using existing tests only