Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28008: Missing try-with-resources in ParquetHiveSerDe #5013

Merged
merged 2 commits into from Jan 21, 2024

Conversation

mlorek
Copy link
Contributor

@mlorek mlorek commented Jan 17, 2024

What changes were proposed in this pull request?

missing close call

Why are the changes needed?

release resources

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

using existing tests only

@mlorek mlorek changed the title HIVE-28008 - added missing try-with-resources in ParuetHiveSerDe HIVE-28008: Missing try-with-resources in ParuetHiveSerDe Jan 17, 2024
@mlorek mlorek changed the title HIVE-28008: Missing try-with-resources in ParuetHiveSerDe HIVE-28008: Missing try-with-resources in ParquetHiveSerDe Jan 17, 2024
@mlorek mlorek marked this pull request as ready for review January 17, 2024 14:20
Copy link

@aturoczy aturoczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@zhangbutao zhangbutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this change to get a green CI?

@mlorek
Copy link
Contributor Author

mlorek commented Jan 20, 2024

cc @ayushtkn

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ayushtkn
Copy link
Member

@zhangbutao is it good with you to merge this, we have a green build now. I am holding this for you

Copy link
Contributor

@zhangbutao zhangbutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn ayushtkn merged commit 5093bb1 into apache:master Jan 21, 2024
6 checks passed
@mlorek mlorek deleted the HIVE-28008-parquet-serde-fix branch February 7, 2024 09:48
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Feb 9, 2024
…chema (apache#5013). (Michal Lorek, reviewed by Ayush Saxena, Butao Zhang, Attila Turoczy)
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Mar 7, 2024
…chema (apache#5013). (Michal Lorek, reviewed by Ayush Saxena, Butao Zhang, Attila Turoczy)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants