Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-28030: LLAP util code refactor #5030

Merged
merged 2 commits into from Jan 25, 2024
Merged

HIVE-28030: LLAP util code refactor #5030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c83215f
LLAP util code refactor
deniskuzZ Jan 24, 2024
382a402
Update LlapSignerImpl.java
deniskuzZ Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapSignerImpl.java
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@
package org.apache.hadoop.hive.llap.security;

import java.io.IOException;
import java.util.Arrays;
import java.security.MessageDigest;

import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.security.UserGroupInformation;
Expand Down Expand Up @@ -58,7 +58,9 @@ public SignedMessage serializeAndSign(Signable message) throws IOException {
public void checkSignature(byte[] message, byte[] signature, int keyId)
throws SecurityException {
byte[] expectedSignature = secretManager.signWithKey(message, keyId);
if (Arrays.equals(signature, expectedSignature)) return;
if (MessageDigest.isEqual(signature, expectedSignature)) {
return;
}
throw new SecurityException("Message signature does not match");
}

Expand Down