HIVE-27938: Iceberg: Fix java.lang.ClassCastException during vectoriz… #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed reads on partition columns
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
|
|
Thanks @SourabhBadhya ! |
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Feb 9, 2024
…ed reads on partition columns (apache#5048) (Simhadri Govindappa reviewed by Sourabh Badhya)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…ed reads on partition columns (apache#5048) (Simhadri Govindappa reviewed by Sourabh Badhya)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed reads on partition columns
What changes were proposed in this pull request?
Add HiveIdentityPartitionConverters.java for converting partitions datatypes .
Why are the changes needed?
In this pull request apache/iceberg#1130 - Identity Partitioning: Introduced a iceberg specific constants map to convert data from java internal representations (e.g., long for timestamps) to Iceberg generics (LocalDateTime or OffsetDateTime for timestamps) .
A similar constants map is required for Hive as quoted in the following discussion.
Without this change, vectorised read queries on partition columns fail with java.lang.ClassCastException for DATE, TIMESTAMP and DECIMAL datatypes as described in the jira https://issues.apache.org/jira/browse/HIVE-27938 .
Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
How was this patch tested?
Qfile :
iceberg_partition_vectorized_read.q