HIVE-27850: Addendum: Add DB name in Iceberg Major compaction query t… #5074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
reviewed
Feb 8, 2024
...-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2024
...-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergMajorQueryCompactor.java
Outdated
Show resolved
Hide resolved
…o fix compaction issue in Cloud env.
difin
force-pushed
the
hive_iceberg_compact_addendum
branch
from
008e445
to
17dcf4c
Compare
|
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…action query (Dmitriy Fingerman, reviewed by Denys Kuzmenko) Closes apache#5074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o fix compaction issue in Cloud env.
What changes were proposed in this pull request?
Add DB name into the query for Iceberg Major QB compaction.
Why are the changes needed?
The existing code works fine in q-tests, but the Iceberg Compaction fails in a cloud env because the compaction query is missing DB name. In Hive ACID QB compaction, DB name is part of the query and it was missed to add in Hive Iceberg compaction code. The reason why it works in q-tests is because the tables are created in the default DB, while in a cloud env they are not created in the default DB.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
I did remote debugging in the cloud env where the Hive Iceberg compaction was failing. I modified the compaction query manually in the debugger by adding the DB name and compaction passed.