HIVE-27850: Iceberg: Addendum 2: Set runAs user in CompactionInfo. #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…itriy Fingerman, reviewed by Denys Kuzmenko) Closes apache#5100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Setting CompactionInfo.runAs in Iceberg Compaction Service.
Why are the changes needed?
Without runAs set, execution fails during compilation phase on access authorization in internal environments.
Besides that, if runAs is not set and Iceberg compaction throws any exception, without this fix there will be also another exception thrown in the catch block here:
hive/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
Line 258 in a348e5d
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Testing with dev jars on local dev env and precommit tests.