HIVE-28102: Iceberg: Invoke validateDataFilesExist for RowDelta operations. #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converted to draft: we need to referenced data files during in delete files, will push a new commit |
|
Changed to validate the referenced data files in the delete files, will see how the build reacts, if all calm will do some touchups & call for review |
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
deniskuzZ
reviewed
Mar 4, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/FilesForCommit.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
...erg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
...iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveIcebergDeleteWriter.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/FilesForCommit.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/FilesForCommit.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/FilesForCommit.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/FilesForCommit.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/FilesForCommit.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/FilesForCommit.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
...erg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
...erg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Mar 4, 2024
...erg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…tions. (apache#5111). (Ayush Saxena, reviewed by Denys Kuzmenko)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Validate Data Files Exist for RowDelta Operations
Why are the changes needed?
RewriteFiles Operations called by compaction jobs(Spark), leads to data corruption when running concurrently with MERGE?UPDATE/DELETE Queries
Does this PR introduce any user-facing change?
Prevents Data corruption
Is the change a dependency upgrade?
No
How was this patch tested?
CI