Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28099: Fix logging in HMS benchmarks #5112

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

InvisibleProgrammer
Copy link
Contributor

The logging is completely broken in HMS benchmarks. When we create a Log entry, it only outputs a format pattern string instead of the log message.

Example output:

%d [%thread] %-5level %logger - %msg

What changes were proposed in this pull request?

TxnHandler refactor introduced Spring and it seems spring logging causes the issue. There are two changes in the PR:

Why are the changes needed?

I want to do some metastore performance benchmarks. It is pretty hard to do that without logging.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

Manually test: java -jar ./target/hmsbench.jar -H localhost --savedata /tmp/benchdata --sanitize -N 100 -N 1000 -o bench_results_direct.csv -C -d testbench_http --params=100 -M "TestGetValidWriteIds" --runMode ACID

@zratkai
Copy link
Contributor

zratkai commented Mar 8, 2024

LGTM.

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kuczoram kuczoram merged commit 8eee4aa into apache:master Mar 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants