HIVE-28104. (2.3) Move HTTP related methods from Utils to HttpUtils in shims #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
Mar 4, 2024
shims/common/src/main/java/org/apache/hadoop/hive/shims/HttpUtils.java
Outdated
Show resolved
Hide resolved
6 tasks
pan3793
commented
Mar 5, 2024
| * Return Hadoop-native RestCsrfPreventionFilter if it is available. | ||
| * Otherwise, construct our own copy of its logic. | ||
| */ | ||
| public static Filter getXSRFFilter() { |
There was a problem hiding this comment.
I'm not sure if the Hive community treats it as a public API, if there are concerns about compatibility, another approach is:
- leaving
Utilsas-is - creating a
HadoopUtils, copying all other methods toHadoopUtils - changing callers to use
HadoopUtilsinstead ofUtilsto avoid initializingUtils
There was a problem hiding this comment.
Sounds like a more compatible solution.
There was a problem hiding this comment.
Either works for me. Looks like this method is only in one place.
sunchao
approved these changes
Mar 15, 2024
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HIVE-13853 added some HTTP-related methods to the shims
Utils, this PR aims to move it to a dedicated classHttpUtilsWhy are the changes needed?
The invocation of any method in
Utilswill trigger all imported classes to be loaded, which blocks the downstream projects from migrating fromjavax.servlet-apitojakarta.servlet-api, see more context at apache/spark#45154 (comment)Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Pass CI(no new failed tests) to ensure everything goes well on the Hive side.
Spark integration tests