Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28037: Run multiple Qtests with Postgres #5118

Merged
merged 1 commit into from Apr 5, 2024

Conversation

zratkai
Copy link
Contributor

@zratkai zratkai commented Mar 5, 2024

Running multiple qtests with Postgre will not fail with "Database does not exist: default". It keeps docker up and running between tests.

What changes were proposed in this pull request?

Changes to be able to run multiple Qtests with Postgre.

Why are the changes needed?

Without this change only one Qtest can be run with Postgre.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

Locally.

Change-Id: I2c37973af59f69d17de733d69f184fe83bcc3091
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zratkai zratkai marked this pull request as ready for review March 7, 2024 08:35
Copy link
Contributor

@InvisibleProgrammer InvisibleProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some explanation about the change?
That description is a little bit confusing:
Change-Id: I2c37973af59f69d17de733d69f184fe83bcc3091

@InvisibleProgrammer
Copy link
Contributor

InvisibleProgrammer commented Mar 26, 2024

Short version: LGTM.

Long version: I checked it out with a PR that uses postgresql driver as a default one to check what happens if we want to run all the qtestst with postgres.
Test run: http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5122/2/tests/
PR: #5122
Diff for the failing tests with only output diff (details below): master...InvisibleProgrammer:hive:HIVE-28037

The PR itself reached it's goal: it had no problem with running multiple qtests with postgres.

Different type of groups of test result

Minor output differences

There were tests that failed but with minor output diff differences. Typically, with having columns in an output in different order or with whitespace differences. I would consider them as a pass. We cannot address those issues as the difference comes from the differences between derby and postgres engine.
Some examples:

  • default_constraint - unique constraints are shown in different order
  • create_with_constraints - key columns in different order
  • drop_partitions_filter.q - Some columns in different order, duplicate key error has different output

Cannot run the tests with explicitly defined postgres driver as the tests are designed to run with postgres:

There are some tests with a comment like --!qt:database:postgres:q_test_country_table.sql
Those tests are failing with unable to start docker container if we add the postgres db parameter to the test execution. I don't think it worth investigating as they are designed to run with postgres and no other driver.
Some examples:

  • qt_database_postgres.q
  • jdbc_partition_table_pruned_pcolumn.q

Failed test cases that worth to fix:

Copy link
Member

@deniskuzZ deniskuzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@deniskuzZ deniskuzZ changed the title HIVE-28037 run multiple Qtest with Postgre HIVE-28037: Run multiple Qtest with Postgres Apr 4, 2024
@deniskuzZ deniskuzZ merged commit c629020 into apache:master Apr 5, 2024
5 checks passed
@deniskuzZ deniskuzZ changed the title HIVE-28037: Run multiple Qtest with Postgres HIVE-28037: Run multiple Qtests with Postgres Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants