-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28037: Run multiple Qtests with Postgres #5118
Conversation
Change-Id: I2c37973af59f69d17de733d69f184fe83bcc3091
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some explanation about the change?
That description is a little bit confusing:
Change-Id: I2c37973af59f69d17de733d69f184fe83bcc3091
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java
Show resolved
Hide resolved
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java
Show resolved
Hide resolved
Short version: LGTM. Long version: I checked it out with a PR that uses postgresql driver as a default one to check what happens if we want to run all the qtestst with postgres. The PR itself reached it's goal: it had no problem with running multiple qtests with postgres. Different type of groups of test resultMinor output differencesThere were tests that failed but with minor output diff differences. Typically, with having columns in an output in different order or with whitespace differences. I would consider them as a pass. We cannot address those issues as the difference comes from the differences between derby and postgres engine.
Cannot run the tests with explicitly defined postgres driver as the tests are designed to run with postgres:There are some tests with a comment like
Failed test cases that worth to fix:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
@zratkai, @InvisibleProgrammer could we please update instructions in https://cwiki.apache.org/confluence/display/Hive/HiveDeveloperFAQ#HiveDeveloperFAQ-HowdoIruntheclientpositive/clientnegativeunittests? |
Running multiple qtests with Postgre will not fail with "Database does not exist: default". It keeps docker up and running between tests.
What changes were proposed in this pull request?
Changes to be able to run multiple Qtests with Postgre.
Why are the changes needed?
Without this change only one Qtest can be run with Postgre.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Locally.