HIVE-21063 : Support statistics in cachedStore for transactional table #514
Conversation
maheshk114
force-pushed
the
HIVE-21063
branch
from
725768d
to
5cddff3
Compare
maheshk114
force-pushed
the
HIVE-21063
branch
from
5cddff3
to
ac6f1eb
Compare
maheshk114
force-pushed
the
HIVE-21063
branch
from
ac6f1eb
to
62a7361
Compare
…e : ptest failure fix after rebase
maheshk114
force-pushed
the
HIVE-21063
branch
from
62a7361
to
4eb5a7b
Compare
| try { | ||
| tableLock.writeLock().lock(); | ||
| PartitionWrapper partitionWrapper = partitionCache.get(CacheUtils.buildPartitionCacheKey(partVals)); | ||
| if (partitionWrapper != null) { |
There was a problem hiding this comment.
What if partitionWrapper is null? If not doing anything, remove if, NPE is better than skip silently (I see couple of places like this).
There was a problem hiding this comment.
in object store if partition is not present we can ignore updating the cache. will modify the code to add log in all places.
| boolean areAllPartsFound = true; | ||
| long partsFound = 0; | ||
| long partsFound = partNames.size(); | ||
| Map<List<String>, Long> partNameToWriteId = writeIdList != null ? new HashMap<>() : null; |
There was a problem hiding this comment.
Is the logic for get_aggr_stats_for different than ObjectStore? I see in ObjectStore, stats are aggregated anyway as long as partitions are valid:
for (Partition part : parts) {
if (!isCurrentStatsValidForTheQuery(part, part.getWriteId(), writeIdList, false)) {
.......
return null;
}
}
}
return get_aggr_stats_for(catName, dbName, tblName, partNames, colNames);
There was a problem hiding this comment.
The behavior is same as objet store ...if partition is not present then ignore, but if partition is present and is not compatible then return null.
…e : after review comment fix
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
No description provided.