HIVE-28226: Split Replication Commands from HiveParser.g. #5220
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
|
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| parser grammar ReplClauseParser; |
There was a problem hiding this comment.
Will we consider using Antlr4 in the future? IMO, most of OSS use Antlr4, and only Hive uses Antlr3, and Antlr has not been updated for many years & Antlr4 is more easy to use than Antlr3.
It would be great if we could incrementally update HiveParser.g it to a higher version HiveParser.g4. :)
A related uncompleted PR is #4058.
This comment may go beyond the scope of the PR. We can make this change happen in the future.
There was a problem hiding this comment.
Yahh, there are some efforts going on for Antlr4, but that might take some time. But we should definitely give it a shot, will explore how things can move there
this change anyway shouldn’t impact that upgrade efforts I believe, this one is just a basic refactor :-)
What changes were proposed in this pull request?
Refactor HiveParser to split Replication Commands
Why are the changes needed?
Reduce HiveParser size
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Existing Tests