HIVE-28215: Signalling CONDITION HANDLER is not working in HPLSQL. #5231
Conversation
| if (userDefinedSignals.size() > 0) { | ||
| for (int i = userDefinedSignals.size() - 1; i >= 0; i--) { |
There was a problem hiding this comment.
Is this check necessary? If userDefinedSignals is empty the loop doesn't executed.
| @@ -1028,9 +1028,13 @@ void cleanup() { | |||
| * Output information about unhandled exceptions | |||
| */ | |||
| public void printExceptions() { | |||
| List<Signal> userDefinedSignals = new ArrayList<>(); | |||
There was a problem hiding this comment.
Is it allowed to add the same Signal more than one times?
Does the order of Signals matter?
There was a problem hiding this comment.
Is it allowed to add the same Signal more than one times?
As per code, same signal is not getting added more than once.
Does the order of Signals matter?
Here to store the signals Stack data structure is getting used so might be the order matters thats why pushing the userdefined signals in the same order which they were present in Stack before processing other signals.
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
|
HIVE-28215: Signalling CONDITION HANDLER is not working in HPLSQL.
What changes were proposed in this pull request?
Currently the CONDITION HANDLERs defined by user are not getting invoked when the signal is given to the corresponding condition. As a part of processing exception/error handling conditions, user defined conditions also processed (just looging into the log file) so when it has to invoke user defined condition handlers there are no condition handlers in the stack.
Why are the changes needed?
To fix the issue of invoking user defined condition handlers properly.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -Dtest=TestHplSqlViaBeeLine -pl itests/hive-unit -Pitests