HIVE-28260: CreateTableEvent wrongly skips authorizing DFS_URI for managed table. #5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aturoczy
approved these changes
May 14, 2024
|
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Jun 13, 2024
…naged table. (apache#5250). (Ayush Saxena, reviewed by Sourabh Badhya, Attila Turoczy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Correct the check to restore proper behaviour
Why are the changes needed?
The check is wrong, the string needs to be compared using equals
Does this PR introduce any user-facing change?
Yes, the URI will be validated during create for managed table
Is the change a dependency upgrade?
No
How was this patch tested?
👀