HIVE-28286: Add filtering support for get_table_metas (Naveen Gangam) #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfsii Could you review this change please? |
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Show resolved
Hide resolved
| return tableMetas; | ||
| String catName = null; | ||
| String dbName = null; | ||
| if (tableMetas != null) { |
There was a problem hiding this comment.
If "tableMetas" is empty, can it throw ArrayOutOfBound exception?
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
zratkai
reviewed
May 30, 2024
| throws MetaException { | ||
| return filterTableMetas(tableMetas); | ||
| if (LOG.isDebugEnabled()) { |
There was a problem hiding this comment.
No need to check LOG.isDebugEnabled(), since LOG.debug will only output, when debug level logging is enabled.
zratkai
reviewed
May 30, 2024
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
zratkai
reviewed
May 30, 2024
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
jfsii
reviewed
May 30, 2024
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Show resolved
Hide resolved
...g/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
|
dengzhhu653
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
I think we have addressed the comments, it would be nice if someone can take an extra eye, cc @jfsii @mayankkunwar @zratkai. Thank you in advance!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the filterTableMetas() method in the HiveMetastoreAuthorizer is a no-op. It returns the full set of tables that are passed into it. This prevents any filtering that is to be done.
This PR adds logic to be able to filter out the ones that the user does not have access to.
Why are the changes needed?
To enhance security in HMS.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Tested manually in a Ranger enabled environment.