Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-22101: table RUNTIME_STATS Schema Script for Postgres Metastore … #750

Closed

Conversation

sam-an-cloudera
Copy link
Contributor

…is wrong (Sam An via Naveen Gangam)

In Postgres SQL script, identifiers such as table, index, and column names need to be quoted to stay in CAPS. This PR fixes for table RUNTIME_STATS.

@@ -1815,14 +1815,14 @@ CREATE TABLE REPL_TXN_MAP (
PRIMARY KEY (RTM_REPL_POLICY, RTM_SRC_TXN_ID)
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a released version. We should not update that as we will have multiple variants of 3.0.0 schema. Same for 3.1.0 schema

@@ -323,14 +323,14 @@ CREATE TABLE MIN_HISTORY_LEVEL (

CREATE INDEX MIN_HISTORY_LEVEL_IDX ON MIN_HISTORY_LEVEL (MHL_MIN_OPEN_TXNID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file also shouldn't be changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update upgrade-3.1.0-to-3.2.0.postgres.sql

@github-actions
Copy link

github-actions bot commented Jun 8, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.

@github-actions github-actions bot added the stale label Jun 8, 2020
@github-actions github-actions bot closed this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants