HIVE-22557 Break up DDLSemanticAnalyzer - extract Table constraints analyzers #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamachor
reviewed
Dec 13, 2019
| /** | ||
| * Reveals the actual type of an ASTTree that has a category as main element. | ||
| */ | ||
| public interface DDLSematnicAnalyzerCategory { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor it in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
Step #10: extract the table constraints related analyzers from DDLSemanticAnalyzer, and move them under the new package.
Also modified the framework to be able to handle
alter table ...statements.Also moved some of the Constraint related utility functions from BaseSemanticAnalyzer to the ddl.table.constraint package, into a new ConstraintUtils class.
Also fixed the typo in the package name: constaint -> constraint