Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Show version string in terminal at startup and in the about box with 'copy to clipboard' button. #2153

Closed
usbrandon opened this issue Jan 13, 2023 · 5 comments
Labels
Milestone

Comments

@usbrandon
Copy link
Contributor

What would you like to happen?

We need to help people help us. They can do this by being precise about the Hop version or Snapshot build they report issues on.

We need each CLI command to support --version flags that output the current Hop version being used.

If the Hop version is currently under development use the SNAPSHOT-yyyMMdd format, otherwise the current release version, example 2.2.0.

When showing the current version on the About Box in the GUI, there should be a dedicated button on the dialog "Copy version to clipboard," which will only copy that detail appropriate for pasting in Github issues asking for the version. There can be another copy to the clipboard button that grabs the rest of ultra-detailed libraries, variables etc, but we just need a simple way to let folks communicate their version.

Issue Priority

Priority: 2

Issue Component

Component: Hop Gui

@github-actions github-actions bot added Hop Gui P2 Default Priority labels Jan 13, 2023
nadment added a commit that referenced this issue Jan 14, 2023
- hop-conf
- hop-run
- hop-search
- hop-import
@nadment nadment self-assigned this Jan 14, 2023
nadment added a commit that referenced this issue Jan 15, 2023
- hop-conf
- hop-run
- hop-search
- hop-import
Add documentation for -v version information
AboutDialog use HopVersionProvider
Can copy version text in AboutDialog
hansva added a commit that referenced this issue Jan 17, 2023
Add option -v --version to print version in the CLI #2153
@nadment nadment removed their assignment Feb 6, 2023
@nadment
Copy link
Contributor

nadment commented Feb 6, 2023

I leave the ticket open for a SNAPSHOT-yyyyMMdd version format

@campen
Copy link
Contributor

campen commented Feb 7, 2023

I would like to have the version info available as a variable that can be utilized in various ways when running workflows/pipelines (like writing the version to the log upon start of the workflow). Should this be a separate ticket?

nadment added a commit that referenced this issue Feb 13, 2023
Specification-Version: 2.4.0-SNAPSHOT
Implementation-Version: 2.4.0-SNAPSHOT (2023-02-13 08.50.52)
nadment added a commit that referenced this issue Feb 13, 2023
Specification-Version: 2.4.0-SNAPSHOT
Implementation-Version: 2.4.0-SNAPSHOT (2023-02-13 08.50.52)
nadment added a commit to nadment/hop that referenced this issue Feb 13, 2023
…che#2153

Specification-Version: 2.4.0-SNAPSHOT
Implementation-Version: 2.4.0-SNAPSHOT (2023-02-13 08.50.52)
@nadment nadment self-assigned this Feb 13, 2023
@nadment
Copy link
Contributor

nadment commented Feb 13, 2023

We should systematically add a line at the beginning of the log with the version when we execute a pipeline or workflow, without having to use a variable.

2023/02/13 22:32:21 - Hop - Pipeline opened.
2023/02/13 22:32:21 - Hop - Launching pipeline [expression_test]...
2023/02/13 22:32:21 - Hop - Implementation version 2.4.0-SNAPSHOT (2023-02-13 08.50.52)
2023/02/13 22:32:21 - Hop - Started the pipeline execution.

@nadment
Copy link
Contributor

nadment commented Feb 13, 2023

But it is also possible to define a system variable if needed, do you think it's useful?
hop.specification.version=2.4
HOP_VERSION=2.4.0-SNAPSHOT (2023-02-13 08.50.52)

@campen
Copy link
Contributor

campen commented Feb 13, 2023

Yes, it would be useful also.

nadment added a commit to nadment/hop that referenced this issue Feb 15, 2023
…che#2153

Specification-Version: 2.4
Implementation-Version: 2.4.0-SNAPSHOT (2023-02-13 08.50.52)
nadment added a commit to nadment/hop that referenced this issue Feb 18, 2023
…che#2153

Specification-Version: 2.4
Implementation-Version: 2.4.0-SNAPSHOT (2023-02-13 08.50.52)
hansva added a commit to nadment/hop that referenced this issue Feb 22, 2023
hansva added a commit that referenced this issue Feb 22, 2023
Maven add the build date in the MANIFEST.MF file to complete issue #2153
@nadment nadment removed their assignment Mar 7, 2023
@hansva hansva added this to the 2.4 milestone Apr 2, 2024
@hansva hansva closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants