Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: can't create project in non-existing folder #2303

Closed
bamaer opened this issue Feb 10, 2023 · 1 comment
Closed

[Bug]: can't create project in non-existing folder #2303

bamaer opened this issue Feb 10, 2023 · 1 comment
Assignees
Labels
bug Hop Gui P2 Default Priority
Milestone

Comments

@bamaer
Copy link
Contributor

bamaer commented Feb 10, 2023

Apache Hop version?

SNAPSHOT-20230210

Java version?

openjdk version "11.0.17" 2022-10-18

Operating system

Linux

What happened?

Observed behavior: when a project is created in a non-existing folder, Hop GUI shows a pop-up that asks the user if the folder needs to be created. The project dialog keeps focus, the yes/no options in this pop-up dialog can't be clicked,
image

Expected behavior: clickable yes/no options in the pop-up dialog.

Issue Priority

Priority: 2

Issue Component

Component: Hop Gui

@mattcasters
Copy link
Contributor

It happens when the parent of the dialog isn't correct. The parent of an SWT shell should always be the dialog where it is called. I already fixed a number of instances where HopGui.getInstance().getShell() and this is probably another one of these cases.

@nadment nadment self-assigned this Feb 15, 2023
hansva added a commit that referenced this issue Feb 18, 2023
Fix issue #2303: can't create project in non-existing folder
@nadment nadment closed this as completed Feb 19, 2023
@hansva hansva added this to the 2.4 milestone Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hop Gui P2 Default Priority
Projects
None yet
Development

No branches or pull requests

4 participants