Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Simplify Hop Web Beam image #2884

Closed
hansva opened this issue Apr 28, 2023 · 1 comment
Closed

[Task]: Simplify Hop Web Beam image #2884

hansva opened this issue Apr 28, 2023 · 1 comment
Assignees
@hansva
Labels
Beam Containers P2 Default Priority task
Milestone
2.5

Comments

@hansva
Copy link
Contributor

hansva commented Apr 28, 2023

What needs to happen?

Currently, all logic has been duplicated between hop-web and hop-web Beam.
We can extend the base image to include the beam fat-jar.

Issue Priority

Priority: 2

Issue Component

Component: Beam, Component: Containers
@github-actions github-actions bot added P2 Default Priority Beam Containers labels Apr 28, 2023
@hansva
Copy link
Contributor Author

hansva commented Apr 28, 2023

.take-issue

@hansva hansva added this to the 2.5 milestone Apr 28, 2023
@hansva hansva closed this as completed in 62d2712 Apr 28, 2023
hansva added a commit that referenced this issue Apr 28, 2023
@hansva
Merge pull request #2885 from hansva/master
d289b88 
Simplify the Hop Web image including beam, fixes #2884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansva hansva

Labels
Beam Containers P2 Default Priority task
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
1 participant
@hansva