[Bug]: "Select values": Button "Get fields to select" not working when there are already fields listed

[gertwieland]

Apache Hop version?

2.5

Java version?

openjdk 11.0.19 2023-04-18 OpenJDK Runtime Environment OpenLogic-OpenJDK (build 11.0.19+7-adhoc..jdk11u) OpenJDK 64-Bit Server VM OpenLogic-OpenJDK (build 11.0.19+7-adhoc..jdk11u, mixed mode)

Operating system

Windows

What happened?

The "Get fields to select" button in the "Select values" transform works fine when no fields are listed yet (eg. when using the transform for the first time).

However, it doesn't work when the list is already populated. At this point, pushing the button (for example because the incoming fields have changed) does nothing.

After deleting the current fields manually and then hitting that button again, it states that "There already is data entered, 0 lines were found".

It seems that at this step, it recognizes that there WERE fields before, but then it counts the current fields and finds that there are zero.

And just since we are on it, maybe change (shorten) the message to: "X fields are listed already." (e. g. 7 fields are listed already).

EDIT: I noticed that when the list is basically the same but there are just additional incoming fields, it just adds them without asking "how" they should be added (i.e. the popup in the screenshot above doesn't show up).

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui

[hansva]

Thanks for reporting this @gertwieland! This has been fixed with #3020

[gertwieland]

Thanks a lot, @hansva. I think the JavaScript transform has basically the same (or similar) issue..
I still didn't get to pull and test 2.6. Would you know if that too has been fixed?

[hansva]

It's an issue in all transforms with that button in 2.5. It has been solved globally.

[gertwieland]

Awesome, thanks a lot, @hansva 😊 Aug 6, 2023 5:30:20 a.m. Hans Van Akelyen ***@***.***>:

…

It's an issue in all transforms with that button in 2.5. It has been solved globally. — Reply to this email directly, view it on GitHub[#3142 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AMK5NEYRE5TVSYPAQIULYXTXT5PZVANCNFSM6AAAAAA3FMCOSI]. You are receiving this because you were mentioned.[Tracking image][https://github.com/notifications/beacon/AMK5NE26N6NR2HFN322AGM3XT5PZVA5CNFSM6AAAAAA3FMCOSKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTDLEZTU.gif]