Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOP-3870 #1512

Merged
merged 3 commits into from May 30, 2022
Merged

HOP-3870 #1512

merged 3 commits into from May 30, 2022

Conversation

sramazzina
Copy link
Contributor

@sramazzina sramazzina commented May 30, 2022

HOP-3870 Database name not mandatory when connecting to Clickhouse with the clickhouse provided jdbc driver

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [HOP-XXX] - Fixes bug in SessionManager,
    where you replace HOP-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@hansva hansva merged commit 59e2508 into apache:master May 30, 2022
@zhicwu
Copy link

zhicwu commented Jun 27, 2022

Hi @sramazzina, since it's an in-development version, could you upgrade the JDBC driver to 0.3.2-patch10 for HA support? Also it's better to use all classifier to support protocols like grpc and tcp(via a thin wrapper of ClickHouse native commandline as of now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants