[HOP-3977] Fat JAR generated in hop-web container is missing some dependencies #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the hop-web Docker image, this directory does not exist, and the generation of a fat JAR fails.
This is required for the JAR to work with Cloud Dataflow, and the issue probably happens with other runners too. The directory only exists if this is running in Tomcat.
mattcasters
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fat JAR generated in hop-web container is missing some dependencies
The fat JAR generated with the docker hop-web container is missing all the JARs included in the
libdirectory of Hop, and it only includes the JARs in the Tomcatlibdirectory, and the plugins JARs.This change checks if we are running in Tomcat in the docker hop-web container and in that case, it adds all the Hop lib JARs too.
There is an additional small change, related to HOP-3966: if the
libswtdirectory does not exist, the plugin does not attempt to import JARs from that directory. Attempting that import makes the fat JAR generation fail.