Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOP-4622 Fix Windows batch files #1816

Merged
merged 2 commits into from
Nov 23, 2022
Merged

HOP-4622 Fix Windows batch files #1816

merged 2 commits into from
Nov 23, 2022

Conversation

nadment
Copy link
Contributor

@nadment nadment commented Nov 22, 2022

No description provided.

@hansva
Copy link
Contributor

hansva commented Nov 22, 2022

@nadment, could we keep all .bat files aligned then? now we have 2 ways of adding the classpath

@nadment
Copy link
Contributor Author

nadment commented Nov 22, 2022

Of course, the other batch files have the same problem, I just didn't think about them

@hansva hansva marked this pull request as draft November 23, 2022 08:18
@nadment nadment marked this pull request as ready for review November 23, 2022 21:13
@nadment nadment changed the title HOP-4622 Fix hop-gui.bat HOP-4622 Fix Windows batch files Nov 23, 2022
@hansva hansva merged commit 168cc57 into apache:master Nov 23, 2022
@nadment nadment deleted the HOP-4622 branch May 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants