Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2883 Workflow executor: do not fire consistency check in case there are no result from sub-workflows
I decided it was a better idea to relax the constraints and don't block the execution in case a field in the result stream was missing. This is because if that missing field(s) come from a sub-pipeline respectively called by the workflow's executor sub-workflow, that behavior could be unwanted in case the sub-pipeline does not return any rows (and so any new fields respect to the input result row). I think it would be a good idea to add a flag to re-enable the raise of an exception in case a field of the required results fields list is missing from the results fields list to support certain use-cases. Feel free to add an issue to request this and I will be more than happy to do that. Therefore, currently, the exception will be raised only if there's a difference in datatypes, same as in the original version but now more clean and complete.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:check
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i
.addresses #123
), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.