Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2883 #2897

Merged
merged 1 commit into from
May 17, 2023
Merged

fix #2883 #2897

merged 1 commit into from
May 17, 2023

Conversation

sramazzina
Copy link
Contributor

@sramazzina sramazzina commented May 3, 2023

fix #2883 Workflow executor: do not fire consistency check in case there are no result from sub-workflows

I decided it was a better idea to relax the constraints and don't block the execution in case a field in the result stream was missing. This is because if that missing field(s) come from a sub-pipeline respectively called by the workflow's executor sub-workflow, that behavior could be unwanted in case the sub-pipeline does not return any rows (and so any new fields respect to the input result row). I think it would be a good idea to add a flag to re-enable the raise of an exception in case a field of the required results fields list is missing from the results fields list to support certain use-cases. Feel free to add an issue to request this and I will be more than happy to do that. Therefore, currently, the exception will be raised only if there's a difference in datatypes, same as in the original version but now more clean and complete.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…ase there are no result from sub-workflows
@hansva hansva merged commit 8c29029 into apache:master May 17, 2023
2 checks passed
@sramazzina sramazzina deleted the 2883 branch May 17, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants