Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to maturin 0.13.0 #2

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Upgrade to maturin 0.13.0 #2

merged 1 commit into from
Jul 18, 2022

Conversation

messense
Copy link
Member

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@messense
Copy link
Member Author

I can also contribute GitHub Actions configuration if you want.

@ShiKaiWi
Copy link
Member

I can also contribute GitHub Actions configuration if you want.

Thanks a lot for your contribution. And the Github Actions is necessary for this project and it will be appreciated if you are willing to make it.

ShiKaiWi
ShiKaiWi approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit c82c9ff into apache:main Jul 18, 2022
@messense messense deleted the maturin-0.13 branch July 18, 2022 08:02
@messense
Copy link
Member Author

messense commented Jul 18, 2022 •
edited
Loading

I gotta say, the dependencies pulled from arrow_deps via common_types is crazy for a client library.

https://github.com/CeresDB/ceresdb/blob/bf6cf18dfcf32bdaf5e62cd77496302cd978fc4c/arrow_deps/Cargo.toml#L9-L23

Consider feature-gate client and server code.

@messense messense mentioned this pull request Jul 18, 2022
Closed
@waynexia waynexia mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@messense @CLAassistant @ShiKaiWi