Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable layered memtable in overwrite mode #1533

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

fix: disable layered memtable in overwrite mode #1533

wants to merge 24 commits into from
+294 −100

Commits on May 23, 2024

  1. disable layered memtable in overwrite mode.

    @Rachelint
    Rachelint committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5ee88c6 View commit details
    Browse the repository at this point in the history

  2. make layered memtable disable default.

    @Rachelint
    Rachelint committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6c154a8 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. add layered's options in show create, modify its default value, and a… 

    …dd some related checks.
    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    167cddf View commit details
    Browse the repository at this point in the history

  2. remove the unnecessary checks.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    578ba7e View commit details
    Browse the repository at this point in the history

  3. update it results.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    bb6562f View commit details
    Browse the repository at this point in the history

  4. add case for create table with invalid options.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    453d8d6 View commit details
    Browse the repository at this point in the history

  5. complete tests.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7a2562e View commit details
    Browse the repository at this point in the history

  6. reset test cases for cluster mode.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e895c29 View commit details
    Browse the repository at this point in the history

  7. fix create table case for local mode.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4df1e7c View commit details
    Browse the repository at this point in the history

  8. add alter case for layered memtable options check.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8a3ac49 View commit details
    Browse the repository at this point in the history

  9. fix clippy.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    61658a6 View commit details
    Browse the repository at this point in the history

  10. remove unnecessary config.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7d7e7af View commit details
    Browse the repository at this point in the history

  11. fix comment.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    390718f View commit details
    Browse the repository at this point in the history

  12. return reason when options are invalid.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1558ffd View commit details
    Browse the repository at this point in the history

  13. fix style.

    @Rachelint
    Rachelint committed May 24, 2024
    Configuration menu
    Copy the full SHA
    14452aa View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. update TableOptions pb.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    9cadf32 View commit details
    Browse the repository at this point in the history

  2. update check logic of layered memtable enabling.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a9c4041 View commit details
    Browse the repository at this point in the history

  3. add compatibility logic during convert table opts pb to table opts.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8057329 View commit details
    Browse the repository at this point in the history

  4. update it results.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    bf1115a View commit details
    Browse the repository at this point in the history

  5. modify TableOptions related displays.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8454986 View commit details
    Browse the repository at this point in the history

  6. fix clippy.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0702f7d View commit details
    Browse the repository at this point in the history

  7. use disable in pb to impl enable default true.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    44655d6 View commit details
    Browse the repository at this point in the history

  8. fix comment.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    1f2ea70 View commit details
    Browse the repository at this point in the history

  9. fix style.

    @Rachelint
    Rachelint committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c400aea View commit details
    Browse the repository at this point in the history