feat: support INSERT INTO SELECT #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dracoooooo Hi, it seems there are some CI errors, would you mind take a look? |
Due to #1538, the newly added integration test seems unable to consistently pass in the cluster environment. |
jiacai2050
reviewed
Jul 9, 2024
There was a problem hiding this comment.
As said in #1538 (comment), sql with multiple tables may fails, so currently we can only enable this features in standalone mode.
In cluster mode, we can do a check to ensure tables belonging to same instance.
For now, you can move this test under local dir, something like integration_tests/cases/env/local/dml/insert_into_select.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #557.
Detailed Changes
When generating the insert logical plan, alse generate the select logical plan and store it in the insert plan. Then execute the select logical plan in the insert interpreter, convert the result records into RowGroup and then insert it.
Test Plan
CI