Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTPCLIENT-2043] Rename classes documented as factories from *Provider #194

Merged
merged 1 commit into from Dec 31, 2019
Merged

[HTTPCLIENT-2043] Rename classes documented as factories from *Provider #194

merged 1 commit into from Dec 31, 2019

Conversation

garydgregory
Copy link
Member

to *Factory.

@michael-o
Copy link
Member

Looking into...

@michael-o michael-o force-pushed the HTTPCLIENT-2043_Provider_to_Factory branch from cfc7d06 to 0beee75 Compare December 31, 2019 16:22
@michael-o
Copy link
Member

Added:
This should be IgnoreCookieSpecFactory. The sole name IgnoreSpecFactory is too broad.

@garydgregory garydgregory merged commit eaa8c5f into apache:master Dec 31, 2019
asfgit pushed a commit that referenced this pull request Dec 31, 2019
@garydgregory
HTTPCLIENT-2043: Rename classes documented as factories from *Provider
711672a 
#194.
@garydgregory
Copy link
Member Author

Thanks @michael-o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@garydgregory @michael-o